search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.53k stars 32.19k forks source link

[codemod] Jss to styled does not support keyframes #30801

Open hongNianYS opened 2 years ago

hongNianYS commented 2 years ago

Duplicates

Latest version

Current behavior 😯

when i run npx @mui/codemod v5.0.0/jss-to-style gived by your team tool to update jss to styled, something errro with the keyframe。 here is my code https://codesandbox.io/s/mui-v5-styled-w-css-keyframes-forked-xecl1?file=/index.js:0-1057

Expected behavior 🤔

convert jss to emotion

Steps to reproduce 🕹

Steps:

run npx @mui/codemod v5.0.0/jss-to-styled pages/index.jsc

Context 🔦

No response

Your environment 🌎

"@mui/material": "^5.3.0",
"@mui/styles": "^5.3.0",
mnajdova commented 2 years ago

@siriwatknp do we support keyframes in the logic for the codemod for transforming jss to styled? I don't think we do.

hongNianYS commented 2 years ago

OK ... so, how do i ues keyframe in mui 5, i have searched some topics, but not work

siriwatknp commented 2 years ago

@siriwatknp do we support keyframes in the logic for the codemod for transforming jss to styled? I don't think we do.

Yes, the Codemod does not transform the keyframes at this point.

siriwatknp commented 2 years ago

OK ... so, how do i ues keyframe in mui 5, i have searched some topics, but not work

Good point, I think we need to add doc about how to use keyframe also.

aymanxdev commented 2 years ago

@hongNianYS You can refer to this #24851 and see if that resolves the issue. Also, have a look at CircularProgress as @mnajdova already mentioned in the same issue mentioned above.