search

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[LoadingButton] Displaying incorrect warning #31235

Open songhobby opened 2 years ago

songhobby commented 2 years ago

Duplicates

Latest version

Current behavior 😯

<LoadingButton loadingPosition="start" .. .>...

This would prompt a warning

Warning: Failed prop type: MUI: The loadingPosition="start" should be used in combination with startIcon.'

However, the default loadingIndicator is used and a startIcon is not necessary here

Expected behavior 🤔

No warning

Steps to reproduce 🕹

No response

Context 🔦

No response

Your environment 🌎

No response

andrebnassis commented 2 years ago

Here there is a repository with a LoadingButton sample that you can reproduce the warning message: https://github.com/andrebnassis/my-lab/tree/issue/mui/31365

shkhalid commented 1 year ago

+1

nishina-y commented 1 year ago

+1

buzzb0x commented 1 year ago

Hi there, any updates on this? Has this been fixed already? I'm on @mui/lab@5.0.0-alpha.105 and the warning is still present

CorentinR3 commented 1 year ago

+1

baki-kucukcakiroglu commented 8 months ago

+1. I can confirm this issue still exists at "@mui/lab": "^5.0.0-alpha.142".

ZeeshanTamboli commented 6 months ago

It works well in Joy UI without any warning. See - https://mui.com/joy-ui/react-button/#loading-position.

mmoreno2-rbi commented 3 months ago

+1

andrew-amp commented 3 months ago

+1

woigl commented 3 months ago

+1

simarmannsingh commented 1 week ago

+1. Still getting a warning for @mui/lab": "^5.0.0-alpha.170".