mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.24k stars 32.11k forks source link

[docs] duplicate information of size in floating action button when language is chinese #33791

Closed PunitSoniME closed 10 months ago

PunitSoniME commented 2 years ago

Duplicates

Latest version

Current behavior 😯

image

Expected behavior 🤔

image

Steps to reproduce 🕹

Steps:

  1. Go to https://mui.com/zh/material-ui/react-floating-action-button/#size and check the information of size ( language should be chinese )

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo ``` System: OS: Windows 10 10.0.19044 Binaries: Node: 16.13.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.10 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 8.12.2 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: Not Found Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.77) npmPackages: @emotion/react: ^11.9.3 => 11.9.3 @emotion/styled: ^11.9.3 => 11.9.3 @mui/base: 5.0.0-alpha.92 @mui/codemod: 5.9.3 @mui/docs: 5.9.3 @mui/envinfo: 2.0.6 @mui/icons-material: 5.8.4 @mui/joy: 5.0.0-alpha.39 @mui/lab: 5.0.0-alpha.93 @mui/markdown: 5.0.0 @mui/material: 5.9.3 @mui/material-next: 6.0.0-alpha.47 @mui/private-theming: 5.9.3 @mui/styled-engine: 5.8.7 @mui/styled-engine-sc: 5.9.3 @mui/styles: 5.9.3 @mui/system: 5.9.3 @mui/types: 7.1.5 @mui/utils: 5.9.3 @mui/x-data-grid: 5.13.0 @mui/x-data-grid-generator: 5.13.0 @mui/x-data-grid-premium: 5.13.0 @mui/x-data-grid-pro: 5.13.0 @mui/x-date-pickers: 5.0.0-alpha.3 @mui/x-date-pickers-pro: 5.0.0-alpha.3 @mui/x-license-pro: 5.12.3 @types/react: ^18.0.14 => 18.0.14 react: ^18.2.0 => 18.2.0 react-dom: ^18.2.0 => 18.2.0 styled-components: 5.3.5 typescript: ^4.6.4 => 4.6.4 ```
PunitSoniME commented 2 years ago

Should I convert the the text into chinese and create a PR or should I just remove the duplicate information ?

@oliviertassinari @siriwatknp @michaldudak

oliviertassinari commented 2 years ago

@PunitSoniME We need to fix this in https://translate.mui.com

PunitSoniME commented 2 years ago

@oliviertassinari

I am totally new to this, Is there anyone who can guide me how to use this ?

michaldudak commented 2 years ago

I selected the correct translation on Crowdin. It'll be included when with the next translations PR.

oliviertassinari commented 2 years ago

We have reported a year ago to Crowdin about this duplication of string bugs, they said they fixed it, but AFAIK, they didn't. It's a highly problematic bug, it makes it worse to translate than keeping the content in English only. #33445 will solve this.

oliviertassinari commented 10 months ago

We have removed the translations since #33445. I'm closing, it's no longer a problem in the docs.

Going forward, I definitely think that we should translate all the docs into Chinese: #39524.