search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.74k stars 32.24k forks source link

Feature Request: extend trigger of TouchRipple to FormControlLabel #33996

Open ghost opened 2 years ago

ghost commented 2 years ago

Duplicates

Latest version

Summary 💡

When using a component built upon MuiButtonBase, for example, CheckBox, the TouchRipple animation triggers when user clicks the component. Very good.

When such a component is wrapped with FormControlLabel to provide an adjacent label, currently the TouchRipple animation is unaffected by the label.

When label exists, would request the ability to extend the trigger for the TouchRipple animation to include the label. Of course the animation itself would not extend to the label, just the trigger.

Result: Touch the label, see the checkbox change state with a ripple.

michaldudak commented 2 years ago

I think it's a sensible request. However, unless there's a significant number of upvotes from the community, we won't have the bandwidth to implement this. Feel free to open a PR if you'd like to give it a shot.