search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.74k stars 32.24k forks source link

Reactify missing as dependency #344

Closed 0x80 closed 9 years ago

0x80 commented 9 years ago

Not sure if this one can be blamed on material-ui at all. If I use browserify on material-ui, and I don't have reactify installed I get this error:

Running "browserify:vendor" (browserify) task
>> Error: ENOTDIR, stat '/Users/me/myproject/node_modules/material-ui/node_modules/react-draggable2/index.js/node_modules/reactify'

I'm not using reactify myself since I replaced it with 6to5ify/babelify. Shouldn't the reactify module be installed as a dependency of react-draggable2?

luisrudge commented 9 years ago

yeah. I'm having this problem too.

shadowmint commented 9 years ago

+1, having this issue too.

You can work around it by not depending on index.js and instead on specific sub components that don't use react-draggable2, but it's annoying.

weijarz commented 9 years ago

+1 work around it by install reactify on project level.

ranweiler commented 9 years ago

+1 I'm using the same workaround as @weijar. The dependencies of react-draggable2 just need adjustment. I've opened an issue upstream (mikepb/react-draggable#2), along with a PR to fix it (mikepb/react-draggable#3).

mikepb commented 9 years ago

Commit https://github.com/mikepb/react-draggable/commit/9d312687e338987b44a32612e49d44957648b87f removes the dependency on reactify for browserify users by pre-compiling react-draggable. Please let me know if that fixes things (I'm not a browserify user).

Note: the change has not been pushed to NPM or material-ui, but is available for testing.

fourcube commented 9 years ago

+1

ranweiler commented 9 years ago

Thanks to @mikepb, this is fixed for me if material-ui simply updates its dependency on react-draggable2 to ^0.5.0, which is now in NPM.