mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.9k stars 32.26k forks source link

[icons] Add TikTok icon #35100

Open M-Fasciano opened 1 year ago

M-Fasciano commented 1 year ago

Summary 💡

Is it possible to add the TikTok icon?

Examples 🌈

No response

Motivation 🔦

No response

Vivek-Prajapatii commented 1 year ago

Hi @siriwatknp , @M-Fasciano may i pick this up? and can you please guide me as i'm new to this project

siriwatknp commented 1 year ago

This is all the brands we have, I guess we could have TikTok icon as well given its popularity. cc @oliviertassinari @mui/core

Screen Shot 2566-01-24 at 11 29 17
michaldudak commented 1 year ago

We generally don't accept new icons (see #19371). This package is meant to mirror what's available in Material Design Icons.

oliviertassinari commented 1 year ago

TikTok has 1 billion users, I think that with more upvotes on this issue, we could add it, as a convenient helper.

michaldudak commented 1 year ago

Discord supposedly has over 140 million active monthly users and 300 million registered accounts (source: https://www.businessofapps.com/data/discord-statistics), and we rejected its icon. Where do we draw the line?

I'd consider removing all the brand icons in v6 and leaving only the Material Design ones, so we don't need to decide arbitrarily what goes in. If we ever create our own set of icons, we can include the brands there.

samuelsycamore commented 1 year ago

Discord supposedly has over 140 million active monthly users and 300 million registered accounts (source: https://www.businessofapps.com/data/discord-statistics), and we rejected its icon. Where do we draw the line?

+1 for establishing where we draw the line 😁

I'd consider removing all the brand icons in v6 and leaving only the Material Design ones, so we don't need to decide arbitrarily what goes in. If we ever create our own set of icons, we can include the brands there.

Social icons are such a common use case for icon packs, though. I feel like we would be annoying a lot of users by not including them. And I think we would prefer that users not have to leave our ecosystem to get the icons they need.

oliviertassinari commented 1 year ago

and we rejected its icon. Where do we draw the line?

@michaldudak I think that it's a matter of the frequency people add them to their page. The best proxies I'm aware of

  1. the search pattern: https://www.notion.so/mui-org/Product-Analytics-f2e2576203564e6c8dc3429cf305a36f#438ef85b318a4d3d89cb18813c0565ed
  2. upvotes on GitHub issues.
  3. the popularity of the platform.

But maybe the rule of thumb is, can you see it often in these footers?

Screenshot 2023-01-29 at 22 20 32 Screenshot 2023-01-29 at 22 20 16

If yes, add it.

to leave our ecosystem to get the icons they need.

@samuelsycamore We could add docs about how to use https://mui.com/material-ui/icons/#svgicon with https://simpleicons.org/.

stephen-barrow commented 2 weeks ago

so are you going to add it or will have to leave the ecosystem just for one icon

FarzinKhaledi commented 1 week ago

this is how you add TikTok mui icon to nextjs 15 typescript

import SvgIcon from "@mui/material/SvgIcon";

// Custom TikTok icon component const TikTokIcon = (props: any) => ( <SvgIcon {...props} viewBox="0 0 48 48">

);