mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.02k stars 32.3k forks source link

[material-ui][Dialog] Screen reader is not narrating role #36471

Open msftedad opened 1 year ago

msftedad commented 1 year ago

Duplicates

Latest version

Steps to reproduce πŸ•Ή

Link to live example: nice-agnesi-s3wxpw - CodeSandbox

Steps: 1.Open URL: nice-agnesi-s3wxpw - CodeSandbox 2.Focus lands on the code editor as soon as page gets opened 3.Press Ctrl+f6 key from keyboard then press 1 tab, then again press CTRL+M from keyboard and then press 1 tab to move focus out of editor pane. 4.Press 6 tabs to Navigate to Open dialog control. 5.Now turn on Screen reader, invoke the Open dialog control, and capture the screen reader narration. 6.Verify whether screen reader is announcing the role of the displayed dialog or not.

Current behavior 😯

Once the model title dialog is displayed screen reader is not announcing role information of dialog.

Observation: once user invoked the open dialog control screen reader is announcing as 'Model title close'

Expected behavior πŸ€”

Once the model tittle dialog is displayed screen reader should announce role information of dialog.

Observation: Once user invoked the open dialog control screen reader should announce as 'Model title dialog displayed' and next focus should land on 'close button'

Context πŸ”¦

Users who rely on screen readers are confused if Screen readers are not narrating role of dialog Once the dialog is displayed. User will be unaware of the content if screen reader does not announce all relevant information of dialogs. Issue-202164

https://user-images.githubusercontent.com/93735775/223999060-2b6c2ff8-853f-4905-aec8-aeaadaf53f82.mp4

Your environment 🌎

Test Environment: OS Version: Windows 22H2 (OS Build 22621.1265) Browser: Chrome Version Version 110.0.5481.178 (Official Build) (64-bit) Screen Reader: JAWS 2023.2212.23 ILM, NVDA 2022.3.2 and Narrator #URL: [nice-agnesi-s3wxpw - CodeSandbox](https://codesandbox.io/s/s3wxpw?file=/demo.js)
michaldudak commented 1 year ago

Thanks, I can confirm it's a bug. I've noticed a similar problem occurs on one of our demos: https://mui.com/material-ui/react-dialog/#transitions

oeb01 commented 1 year ago

I'd like to work on this!

msftedad commented 9 months ago

Hi team, Any update on this issue?

DiegoAndai commented 9 months ago

Hey @msftedad, there's an open PR, but it might be abandoned.

The bug is still present, so I'll add the ready-to-take label. Let's see if a contributor is interested in working on it.

@michaldudak, how do you think Base UI plays into this one? Should the role eventually live on Base UI's side?

michaldudak commented 9 months ago

We haven't fleshed out all the details about dialogs in Base UI. I'll take this issue into consideration when designing it.