mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.63k stars 32.22k forks source link

[Masonry] Fix ResizeObserver loop limit exceeded error #37208

Closed hbjORbj closed 1 year ago

hbjORbj commented 1 year ago

Closes https://github.com/mui/material-ui/issues/36909

Problem

Solution

Before

https://user-images.githubusercontent.com/32841130/236841383-a6028744-dbcf-48c6-bf23-5120024ec67f.mov

After

https://user-images.githubusercontent.com/32841130/236841366-aaaf9600-c0ef-41b9-b750-6ab1ab022625.mov

https://codesandbox.io/s/exciting-brattain-p010gm?file=/demo.tsx:0-1249

mui-bot commented 1 year ago

Netlify deploy preview

https://deploy-preview-37208--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by :no_entry_sign: dangerJS against dd50f6b92a67b91eb36a3bb57a74a64b09a2bcbc

SanNic20 commented 1 year ago

@mnajdova : when will it be deployed?

DiegoAndai commented 1 year ago

@hbjORbj may we merge this one? 😊

hbjORbj commented 1 year ago

@SanNic20 This will be deployed on upcoming Monday.

aakif-quayyum commented 1 year ago

Was this implemented as I am still receiving the error (ResizeObserver loop limit exceeded)?

DiegoAndai commented 1 year ago

Hey @aakif-quayyum sorry for this, the error should be fixed in @mui/lab version 5.0.0-alpha.135. Could you try it out in that version and let me know if it's actually fixed?

aakif-quayyum commented 1 year ago

Yes, @DiegoAndai following the release of @mui/lab version 5.0.0-alpha.135 I no longer experieance this error, thanks a lot!

kanon551 commented 1 year ago

Working Fine now Thanks Guys. npm install @mui/lab@5.0.0-alpha.135 I had similar issue, While i had pagination implemented. Everytime when i click on next page to render the cards this ResizeObser Loop exceded error occured. It was very frustating. Now its working fine