mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
92.44k stars 31.84k forks source link

[icons] Include new twitter icon X #38480

Open edx-mostafa-eltahawy opened 10 months ago

edx-mostafa-eltahawy commented 10 months ago

Summary 💡

The current twitter icon available under MUI is the old logo

Examples 🌈

The current twitter icon available under MUI is the old logo TwitterIcon from '@mui/icons-material/Twitter';

Motivation 🔦

The current twitter icon available under MUI is the old logo

abreel commented 10 months ago

@siriwatknp This is my first open source contribution and I want to try looking into this issue. Is that fine?

siriwatknp commented 10 months ago

@abreel Thanks for that! If you are interested, the PR is already open. Can you please take a look if it looks good to you? https://github.com/mui/material-ui/pull/38343

abreel commented 10 months ago

Thanks @siriwatknp

I will like to know which of the images I should use

Screenshot 2023-08-21 at 11 35 37

as the new icon

Screenshot 2023-08-21 at 11 37 10
abreel commented 10 months ago

Thanks @siriwatknp

I will like to know which of the images I should use

Screenshot 2023-08-21 at 11 35 37

as the new icon

Screenshot 2023-08-21 at 11 37 10

They are svg icons

edx-mostafa-eltahawy commented 10 months ago

Thanks @siriwatknp I will like to know which of the images I should use

Screenshot 2023-08-21 at 11 35 37

as the new icon

Screenshot 2023-08-21 at 11 37 10

They are svg icons

I believe the filled one on the right as the current twitter logo is only present in the filled variant as well.

abreel commented 10 months ago

@edx-mostafa-eltahawy Thanks

abreel commented 10 months ago

I have made the needed changes, but honestly don't know where or how to preview. Is there a documentation that could help with checking my changes in the codebase?

@edx-mostafa-eltahawy @siriwatknp

abreel commented 10 months ago

I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated

edx-mostafa-eltahawy commented 10 months ago

I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated

Contributing Guide

edx-mostafa-eltahawy commented 10 months ago

@abreel @siriwatknp any updates regarding the icon?

abreel commented 10 months ago

@edx-mostafa-eltahawy I have tried everything I could think of and still honestly can't find my way around the viewing the icon. I have updated the icon svg file at packages/mui-icons-material/custom/Twitter.js, but I still can't see it change in the browser

Screenshot 2023-09-02 at 07 33 04

and even the localhost:3000/playground returns "not found"

Screenshot 2023-09-02 at 08 10 18 Screenshot 2023-09-02 at 08 10 35
abreel commented 10 months ago

@edx-mostafa-eltahawy @siriwatknp I made a pr to the master branch already

IN2TEC commented 9 months ago

Hey guys, is the new icon up in the libary? I am having difficulties finding it

eriq123 commented 9 months ago

Hey guys, is the new icon up in the libary? I am having difficulties finding it

You can check the Twitter icon update here #38811

iamchandanys commented 8 months ago

Any idea when the new Twitter icon will be out?

oliviertassinari commented 6 months ago

38811 is a step in the right direction but doesn't deliver value.

I think there are more follow-ups needed on this to consider the problem solved:

harsh-ps-2003 commented 6 months ago

@oliviertassinari I am trying to use new X logo (import X from '@mui/icons-material/X') in Thanos-io project was failing. I tried finding the icon in MUI official website, but failed. Got module doesn't exist in my code. Can you please release this icon faster, we need it! Thanks