Open edx-mostafa-eltahawy opened 10 months ago
@siriwatknp This is my first open source contribution and I want to try looking into this issue. Is that fine?
@abreel Thanks for that! If you are interested, the PR is already open. Can you please take a look if it looks good to you? https://github.com/mui/material-ui/pull/38343
Thanks @siriwatknp
I will like to know which of the images I should use
as the new icon
Thanks @siriwatknp
I will like to know which of the images I should use
![]()
as the new icon
![]()
They are svg icons
Thanks @siriwatknp I will like to know which of the images I should use
![]()
as the new icon
![]()
They are svg icons
I believe the filled one on the right as the current twitter logo is only present in the filled variant as well.
@edx-mostafa-eltahawy Thanks
I have made the needed changes, but honestly don't know where or how to preview. Is there a documentation that could help with checking my changes in the codebase?
@edx-mostafa-eltahawy @siriwatknp
I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated
I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated
@abreel @siriwatknp any updates regarding the icon?
@edx-mostafa-eltahawy I have tried everything I could think of and still honestly can't find my way around the viewing the icon. I have updated the icon svg file at packages/mui-icons-material/custom/Twitter.js, but I still can't see it change in the browser
and even the localhost:3000/playground returns "not found"
@edx-mostafa-eltahawy @siriwatknp I made a pr to the master branch already
Hey guys, is the new icon up in the libary? I am having difficulties finding it
Hey guys, is the new icon up in the libary? I am having difficulties finding it
You can check the Twitter icon update here #38811
Any idea when the new Twitter icon will be out?
I think there are more follow-ups needed on this to consider the problem solved:
@oliviertassinari I am trying to use new X logo (import X from '@mui/icons-material/X') in Thanos-io project was failing. I tried finding the icon in MUI official website, but failed. Got module doesn't exist in my code. Can you please release this icon faster, we need it! Thanks
Summary 💡
The current twitter icon available under MUI is the old logo
Examples 🌈
The current twitter icon available under MUI is the old logo
TwitterIcon from '@mui/icons-material/Twitter';
Motivation 🔦
The current twitter icon available under MUI is the old logo