Open Janpot opened 1 year ago
@Janpot @danilo-leal we would like to pick this up
@gitstart Go ahead! 🙌
@danilo-leal @Janpot here is a demo of our proposed solution. Please let us know what you think.
Thank you. To summarize: the proposed solution would be to invert the background color of the Snackbar, which would be a breaking change.
For reference: Material Design 3 specs the colors as inverted. I believe, if we follow spec, the solution would be to invert the colors of disabled state inside of the snackbar as to align them with the inverted background.
@danilo-leal @Janpot to put this in context:
We have observed a conflict between the snackbar background color and the button's disabled state, particularly when the theme is in dark mode.
In light mode:
In dark mode:
Currently, the button is using a more generic theme configuration styling, which is palette.action.disabled
.
We believe the issue could be resolved by reversing the snackbar background color, using a light color in light mode and a dark color in dark mode. However, we acknowledge that this change might be considered a breaking change.
We would like to seek your input on the best way to address this issue. Should we proceed with reversing the snackbar background color, potentially as a breaking change, or do you have alternative suggestions for resolving the conflict?
Duplicates
Latest version
Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/lively-voice-vvlghg?file=/Demo.tsx
Steps:
Current behavior 😯
Buttons are very hard to read. I've added disabled buttons in a theme of the opposite mode for comparison.
In dark mode the button even disappears
Expected behavior 🤔
Disabled buttons are readable in a snackbar
Context 🔦
Ran into this while adding a loading button in the Snackbar
Your environment 🌎
https://codesandbox.io/s/lively-voice-vvlghg?file=/Demo.tsx