mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.09k stars 32.06k forks source link

[icons] Missing "Area Chart" icon #39874

Open bentaly opened 9 months ago

bentaly commented 9 months ago

Duplicates

Latest version

Steps to reproduce 🕹

Link to live example:

As you can see there is an icon called "Area Chart" https://fonts.google.com/icons?icon.set=Material+Icons&selected=Material+Icons+Outlined:area_chart:&icon.query=area+chart

This doe not exist on the mui.com icons demo (or in the package): https://mui.com/material-ui/material-icons/?query=area

Current behavior 😯

It appears some icons are missing - even thought mui.com says: "@mui/icons-material includes the 2,100+ official Material Icons"

Expected behavior 🤔

No response

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo ``` System: OS: macOS 14.1 Binaries: Node: 20.5.1 - ~/.local/share/asdf/installs/nodejs/20.5.1/bin/node Yarn: Not Found npm: 9.8.0 - ~/.local/share/asdf/plugins/nodejs/shims/npm Browsers: Chrome: 119.0.6045.123 Edge: Not Found Safari: 17.1 npmPackages: @emotion/react: ^11.11.1 => 11.11.1 @emotion/styled: ^11.11.0 => 11.11.0 @mui/base: 5.0.0-beta.23 @mui/core-downloads-tracker: 5.14.17 @mui/icons-material: ^5.14.16 => 5.14.16 @mui/material: ^5.14.17 => 5.14.17 @mui/private-theming: 5.14.17 @mui/styled-engine: 5.14.17 @mui/system: 5.14.17 @mui/types: 7.2.8 @mui/utils: 5.14.17 @types/react: ^18.2.15 => 18.2.36 react: ^18.2.0 => 18.2.0 react-dom: ^18.2.0 => 18.2.0 typescript: ^5.0.2 => 5.2.2 ```
mj12albert commented 9 months ago

@bentaly Thanks for reporting this, I believe the icons package needs to be synced once in a while with the official Material Icons: https://github.com/mui/material-ui/tree/master/packages/mui-icons-material#contributing

Would you be interested in creating a PR?

bentaly commented 9 months ago

Hi @mj12albert thanks for letting me know. I'll have a look into this when I get some time, thanks!

PaulKristoffersson commented 9 months ago

@bentaly I made a PR to fix it for you, hope that is ok! @mj12albert I followed the instructions in the link you provided.

bentaly commented 9 months ago

@PaulKristoffersson No problem and thanks! good luck with the MR, I was getting around to it :)

bentaly commented 8 months ago

Hi @mj12albert - is anyone able to take a look at the associated MR?

bentaly commented 7 months ago

Hi all, just wondering if anyone approved can take a look at that PR? Going to have to switch to another icon version of Mui icons if not

siriwatknp commented 6 months ago

@bentaly I could not find the area_chart from https://fonts.google.com/metadata/icons?incomplete=true. Our script could not detect the icon.

For a workaround, you can download the SVG from https://fonts.gstatic.com/s/i/materialiconsround/area_chart/v3/24px.svg and use it like this:

import SvgIcon from '@mui/material/SvgIcon';

<SvgIcon>
  <svg>…
</SvgIcon>
bentaly commented 6 months ago

Thanks @siriwatknp I'm aware I can add work-arounds and then remove them when the library is updated - I just had assumed given it's featured on the mui website that it would be relatively up to date. But thanks for the work around idea