mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[joy-ui][Linear Progress] Add CSS variables types #39900

Closed harry-whorlow closed 1 week ago

harry-whorlow commented 6 months ago

This is a pull request following on from the PR found here create by @sai6855.

The intended purpose is to bring inference to the SX prop for the css variables, as discussed in this comment.

As shown by my demonstion here:

inference-demo

Two points of feedback I am looking for.


Thats all from me... If this is something of interest, I will keep working through the list I created on @sai6855 pull request (comment).

I'm open to feedback so let me know. Looking forward to hearing from you guys!

mui-bot commented 6 months ago

Netlify deploy preview

https://deploy-preview-39900--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 114a7609205f4b7d613be9660459ef913d8890e9

siriwatknp commented 2 months ago

@harry-whorlow @sai6855 I propose we try these out (then merge) in next branch which should be open next week.

harry-whorlow commented 2 months ago

@siriwatknp cool, it's something I think is pretty useful and "love me some type inference" so I'm looking forward to it. 🤟

@DiegoAndai mentioned v6 branch is opening next week Thursday, is this what your referring to by "next"?

siriwatknp commented 2 months ago

mentioned v6 branch is opening next week Thursday, is this what your referring to by "next"?

Yes, that's right!

harry-whorlow commented 2 months ago

Okay, I'll try and get this branch up to scratch.

@sai6855 hope your doing well! A while back I asked about the pnpm proptype command generating a lot of code, across all the components, is this something thats intended? I mean I get why its happening, but I could imagine having 70 files being changed every merge could be hard to review.

Screenshot 2024-03-15 at 10 13 18

Whats your thoughts? I mean perhaps, I've done something wrong, but I see the test_static throwing the same error in your merge, Implying that you've also got large proptype changes.

harry-whorlow commented 1 month ago

@siriwatknp Hi man, just a heads up as I'm a little unsure with how to progress this. But this is what the merge request looks like when running propTypes (commit) at least to me this seems like a lot of code to merge over with every variable thats inferred. I could imagine having a component with multiple css-vars could result in some large files.

Can I get your opinion on how to progress, or perhaps even @sai6855 could enlighten me, it would be much appreciated!

Enjoy the start to your week 🤟

oliviertassinari commented 1 month ago

Joy UI development reached a deadlock. The plan is to rewrite it so Joy Design and Material Design are a skin of the same underlying components, so It seems that the work shouldn't be carried forward from Joy UI today's codebase, so it seems that we can close all the open PRs: https://github.com/mui/material-ui/pulls?q=is%3Apr+is%3Aopen+label%3A%22package%3A+joy-ui%22+ to stay focused.

harry-whorlow commented 2 weeks ago

@oliviertassinari sorry for the delay in response... ah thats a shame, always next time I guess.

I remember in the original thread by @sai6855 there was a reasonable amount of interest in back porting it to Material UI, is this something thats still of interest?

I suppose I could always ask @DiegoAndai for his opinion?

DiegoAndai commented 1 week ago

there was a https://github.com/mui/material-ui/pull/39044#pullrequestreview-1689864609 in back porting it to Material UI, is this something thats still of interest?

It is, but it's on hold because we're unsure how we're going to structure the CSS variables. We'll eventually get back to this, but not at this moment.

harry-whorlow commented 1 week ago

@DiegoAndai okay, cool well if you get round to it give me a ping I'd like to help out 🤟