Closed harry-whorlow closed 1 week ago
https://deploy-preview-39900--material-ui.netlify.app/
Details of bundle changes (Toolpad) Details of bundle changes
Generated by :no_entry_sign: dangerJS against 114a7609205f4b7d613be9660459ef913d8890e9
@harry-whorlow @sai6855 I propose we try these out (then merge) in next
branch which should be open next week.
@siriwatknp cool, it's something I think is pretty useful and "love me some type inference" so I'm looking forward to it. 🤟
@DiegoAndai mentioned v6 branch is opening next week Thursday, is this what your referring to by "next"?
mentioned v6 branch is opening next week Thursday, is this what your referring to by "next"?
Yes, that's right!
Okay, I'll try and get this branch up to scratch.
@sai6855 hope your doing well! A while back I asked about the pnpm proptype command generating a lot of code, across all the components, is this something thats intended? I mean I get why its happening, but I could imagine having 70 files being changed every merge could be hard to review.
Whats your thoughts? I mean perhaps, I've done something wrong, but I see the test_static throwing the same error in your merge, Implying that you've also got large proptype changes.
@siriwatknp Hi man, just a heads up as I'm a little unsure with how to progress this. But this is what the merge request looks like when running propTypes (commit) at least to me this seems like a lot of code to merge over with every variable thats inferred. I could imagine having a component with multiple css-vars could result in some large files.
Can I get your opinion on how to progress, or perhaps even @sai6855 could enlighten me, it would be much appreciated!
Enjoy the start to your week 🤟
Joy UI development reached a deadlock. The plan is to rewrite it so Joy Design and Material Design are a skin of the same underlying components, so It seems that the work shouldn't be carried forward from Joy UI today's codebase, so it seems that we can close all the open PRs: https://github.com/mui/material-ui/pulls?q=is%3Apr+is%3Aopen+label%3A%22package%3A+joy-ui%22+ to stay focused.
@oliviertassinari sorry for the delay in response... ah thats a shame, always next time I guess.
I remember in the original thread by @sai6855 there was a reasonable amount of interest in back porting it to Material UI, is this something thats still of interest?
I suppose I could always ask @DiegoAndai for his opinion?
there was a https://github.com/mui/material-ui/pull/39044#pullrequestreview-1689864609 in back porting it to Material UI, is this something thats still of interest?
It is, but it's on hold because we're unsure how we're going to structure the CSS variables. We'll eventually get back to this, but not at this moment.
@DiegoAndai okay, cool well if you get round to it give me a ping I'd like to help out 🤟
This is a pull request following on from the PR found here create by @sai6855.
The intended purpose is to bring inference to the SX prop for the css variables, as discussed in this comment.
As shown by my demonstion here:
Two points of feedback I am looking for.
Question one: I'm unsure how to proceed as the pull request from @sai6855 has been sat there for three weeks, so I copied over his type utility class... It would be preferred if his pull request could be merged, so he gets the credit for the awesome work he did with the GenerateCssVarsType utility type. If this is the case I'll remove the commit from my PR as I kept it separate. (on a side note, I hope this pull request can bring some attention to his issue, @siriwatknp and @mnajdova you both seemed interested in his solution so perhaps you could bring some attention to this issue. I also saw @oliviertassinari, @brijeshb42 and @DiegoAndai cc'ed in a lot on that issue, so I'll include you here.)
Question two: Theres a commit labelled in my pull called "updated docs"... I'm unsure if I should of used the variables there, instead of the inferred css vars, if not just as before I can remove the commit pending an opinion.
Thats all from me... If this is something of interest, I will keep working through the list I created on @sai6855 pull request (comment).
I'm open to feedback so let me know. Looking forward to hearing from you guys!