I would expect the later cases to be compared against a more generic baseline. Originally this was React primitives, which seems reasonable. Starting with the addition of the Table case, it looks like the impact on baseline selection was not noticed.
Thanks for the suggestion. We'll take this into account when we start adding more benchmarks around the zero-runtime we are working on for v6. cc @brijeshb42
Duplicates
Latest version
Steps to reproduce 🕹
Link to live example:
printMeasure
function that takes a baseline: https://github.com/mui/material-ui/pull/23729/filesSteps:
yarn benchmark:browser
Current behavior 😯
In the output, the first two cases are time measurements and the rest are relative to the baseline, which is set to
Grid (html)
.Expected behavior 🤔
I would expect the later cases to be compared against a more generic baseline. Originally this was
React primitives
, which seems reasonable. Starting with the addition of theTable
case, it looks like the impact on baseline selection was not noticed.Context 🔦
I noticed this while running some custom benchmarks locally after following the link from the docs on performance trade-offs: https://mui.com/system/getting-started/usage/#performance-tradeoffs
Your environment 🌎
``` System: OS: Windows 10 10.0.19045 Binaries: Node: 18.15.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: Not Found Edge: Spartan (44.19041.3570.0), Chromium (119.0.2151.58) npmPackages: @emotion/react: 11.11.1 @emotion/styled: 11.11.0 @mui/base: 5.0.0-beta.24 @mui/codemod: 5.14.18 @mui/core-downloads-tracker: 5.14.18 @mui/docs: 5.14.18 @mui/envinfo: 2.0.13 @mui/icons-material: 5.14.18 @mui/internal-waterfall: 1.0.0 @mui/joy: 5.0.0-beta.15 @mui/lab: 5.0.0-alpha.153 @mui/markdown: 5.0.0 @mui/material: 5.14.18 @mui/material-next: 6.0.0-alpha.110 @mui/private-theming: 5.14.18 @mui/styled-engine: 5.14.18 @mui/styled-engine-sc: 6.0.0-alpha.6 @mui/styles: 5.14.18 @mui/system: 5.14.18 @mui/types: 7.2.9 @mui/utils: 5.14.18 @mui/x-charts: 6.18.1 @mui/x-data-grid: 6.18.1 @mui/x-data-grid-generator: 6.18.1 @mui/x-data-grid-premium: 6.18.1 @mui/x-data-grid-pro: 6.18.1 @mui/x-date-pickers: 6.18.1 @mui/x-date-pickers-pro: 6.18.1 @mui/x-license-pro: 6.10.2 @mui/x-tree-view: 6.17.0 @mui/zero-jest: 0.0.1-alpha.0 @mui/zero-next-plugin: 0.0.1-alpha.0 @mui/zero-runtime: 0.0.1-alpha.0 @mui/zero-tag-processor: 0.0.1-alpha.0 @mui/zero-vite-plugin: 0.0.1-alpha.0 @types/react: ^18.2.37 => 18.2.37 react: 18.2.0 react-dom: 18.2.0 styled-components: 6.1.1 typescript: ^5.1.6 => 5.1.6 ```npx @mui/envinfo