[material-ui] Deprecate `*Component` and `*Props` props

DiegoAndai commented 8 months ago

Part of #40417

Description

Deprecate *Component and *Props props in v6, planned for removal in v7.

These are deprecated in favor of the slot pattern: slots and slotProps
If the slots or slotProps props do not exist:
- They must be implemented in the same PR in which the deprecation is added
- They should have the same type as the deprecated prop
The PR introducing the deprecation must also add:
- A section in the migration guide
- A codemod

Example PR

https://github.com/mui/material-ui/pull/40418

Contributing

Feel free to take any components that still need to be done or in progress. Please mention this issue in your PR so we can link it in the description and keep it up to date.

Components to migrate

ordered by page views

[ ] InputBase
[ ] Input
[ ] FilledInput
[ ] OutlinedInput
[ ] ButtonBase
[ ] Select
[ ] NativeSelect
[x] Autocomplete: #41875
[ ] TablePagination
[ ] TableSortLabel: #42157
[ ] CardHeader
[ ] Menu: #42218
[ ] Dialog: #40687
[ ] Drawer
[ ] SwipeableDrawer
[ ] ListItem: Already deprecated, missing guide and codemod
[ ] ListItemText: #42273
[ ] Tabs
[ ] Checkbox
[x] Accordion: #40418
[ ] Tooltip: #42120 @siriwatknp
[x] Avatar: #40853
[x] Backdrop: #40677
[ ] Modal: missing migration guide and codemod
[ ] MobileStepper
[ ] Popover
[ ] Radio
[ ] Rating
[ ] Snackbar #42314
[x] SpeedDial: #40698
[ ] SpeedDialAction
[ ] StepContent: #42167
[x] StepLabel: #41835
[x] TextField: #42062

Search keywords: deprecation material-ui

harry-whorlow commented 7 months ago

@DiegoAndai Hi man, hope all is well!

Can you mark speed dial as under way 40698. I'll be adding to it over the coming weeks 🤟

DiegoAndai commented 7 months ago

@harry-whorlow done 🙌🏼

DiegoAndai commented 7 months ago

Utils for the codemods of these deprecations were added in https://github.com/mui/material-ui/pull/41685. This makes implementing the codemods easier.

harry-whorlow commented 6 months ago

@DiegoAndai I think I'll take up menu next, I'll create a pull request in the coming days. 🤟

harry-whorlow commented 6 months ago

My draft for menu, if you could mark menu as 'in progress' that would be awesome. 🤟

DiegoAndai commented 5 months ago

Hey everyone! With the core team, we've been discussing that composition might be a better API than slots for these props' use cases. It hasn't been decided yet if we will take this approach, but until we have more clarity, I'm marking this issue as on hold.

For v6, we should revert the deprecation messages we've added. Is someone here interested in opening a PR for that? It should only revert the deprecation messages, not the code itself.

Note that https://github.com/mui/material-ui/issues/41279 is not on hold. We will continue with that one, as having two names for the same thing (components and slots) doesn't make sense.

I'm sorry if you had open PRs and this disappoints you 😓 but we should strive for the best API 🙌🏼 🚀. For the moment, let's close open PRs. I'll keep you updated.

lhilgert9 commented 5 months ago

For v6, we should revert the deprecation messages we've added. Is someone here interested in opening a PR for that? It should only revert the deprecation messages, not the code itself.

@DiegoAndai I could do this.

mui / material-ui