search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.25k stars 32.12k forks source link

[material-ui][Rating] `arrowUp` and `arrowDown` are reversed #41290

Open michelengelen opened 6 months ago

michelengelen commented 6 months ago

Steps to reproduce

Link to live example: Basic Rating

Steps:

  1. tab into the rating
  2. press arrow up/down
  3. value setting is reversed

Current behavior

arrowUp decreases value arrowDown increases value

Expected behavior

arrowUp increases value arrowDown decreases value

Context

No response

Your environment

No response

Search keywords: rating arrow up down value

KirankumarAmbati commented 6 months ago

Is it by design that Rating component behaves this way? Below ones are also working same as material UI: Uber: https://baseweb.design/components/rating/ Ebay: https://opensource.ebay.com/mindpatterns/input/star-rating/

Arrow Left & Right is functioning correctly for all 3 components, including material UI.

michelengelen commented 6 months ago

OK, maybe it is intended behavior ... it just feels so wrong to hit the arrow down key and the value going up!

KirankumarAmbati commented 6 months ago

OK, maybe it is intended behavior ... it just feels so wrong to hit the arrow down key and the value going up!

Agreed.

samuelsycamore commented 6 months ago

As far as I know this is intended behavior. From an a11y perspective I think it would be even more strange if they were reversed from the existing implementation.

michelengelen commented 6 months ago

As far as I know this is intended behavior. From an a11y perspective I think it would be even more strange if they were reversed from the existing implementation.

Yeah ... considering this I think we can close this one! Thanks!