search

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[material-ui][slider] Move palette styles to the bottom #41676

Closed siriwatknp closed 1 month ago

siriwatknp commented 1 month ago

Issue: https://mui.com/material-ui/, see https://github.com/mui/material-ui/pull/41201#issuecomment-2016184215

image

I don't have time to dig down to the root cause at the moment. This is a quick fix to get rid of the styles generation error.

After: https://deploy-preview-41676--material-ui.netlify.app/material-ui/

image
mui-bot commented 1 month ago

Netlify deploy preview

https://deploy-preview-41676--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 40af0c92415477682aef6a2e1905dec7a8dbf021

oliviertassinari commented 4 days ago

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

siriwatknp commented 3 days ago

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

I agree. It's hard for me to let go too but I don't have resource to get into this right now.

I will create an issue for this.