mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.

https://mui.com/material-ui/

MIT License

91.73k stars 31.51k forks source link

[docs-infra] Using the right to left feature with browser translators #42007

Closed fahdmk closed 1 week ago

fahdmk commented 1 week ago

https://mui.com/material-ui/getting-started/

Kind of issue

Unclear explanations

Issue description

I am aware that you have discontinued translating the docs but you left the right to left feature wich is crutial espeatilly for arab users so they can use the browser translator wich works fine despite minor buttons styling problems like this so there is no need to diable these feature completely for now by making the text unreadable

Context

using the right to left feature in material ui v5 with browser translators

Search keywords: right to left translation

danilo-leal commented 1 week ago

so there is no need to diable these feature completely for now by making the text unreadable

Hey @fahdmk, thanks for the issue! Just so I can clarify it — what do you mean by "no need to disable this feature"? Which one exactly? It doesn't seem like the RTL feature is disabled, but the screenshot you attached does apparently show a bug with it.

fahdmk commented 1 week ago

so it is a bug that the test is faint like that ? @danilo-leal

danilo-leal commented 1 week ago

Definitely, yeah — I don't understand why colors are being affected by the RTL config. I need to look this up! @alexfauquette any quick pointers from you right off the bat?

alexfauquette commented 1 week ago

Because emotion adds a class before the :where that breaks the dark mode

41803

@fahdmk The time it gets fixed, you can still use the light mode