search

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[material-ui][InputBase] Deprecate components and componentProps props for v6 #42093

Open ChronicusUA opened 2 weeks ago

ChronicusUA commented 2 weeks ago

Part of: #41279 Deprecate components and componentsProps props

When I added deprecated for InputBase and after running process commands from there I found out that components for Input, FilledInput and OutlinedInput are updated as well. So here the changes for the all 4. If you need to seprate the PR for 4 others (in this case we will have conflicts for migrating-from-deprecated-apis.md and mui-codemod/README.md files after merging 1 by 1) please let me know. It will be great if you run tests for mui-codemod locally on linux/Max machine. I run it on my Windows machine and added some potential fix with line endings. BTW on windows I have some tests are fallen (I didn't change parts related to that tests).

mui-bot commented 2 weeks ago

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against 08ce047490ad6f46caf83aad904ee8d564ea3805

ChronicusUA commented 2 weeks ago

I can see that some tests are fallen. Seems like it is in Alert.js file that I didn't touch

DiegoAndai commented 2 weeks ago

Hey @ChronicusUA! thanks for working on this one 🚀

If you need to seprate the PR for 4 others (in this case we will have conflicts for migrating-from-deprecated-apis.md and mui-codemod/README.md files after merging 1 by 1) please let me know.

We can keep all 4 components in this PR, as the types all come from the same place (InputBase.d.ts)

I can see that some tests are fallen. Seems like it is in Alert.js file that I didn't touch

This is a flaky test on our CI, so don't worry about it at the moment 😊

I'll review this one in more detail on Monday