search

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[material-ui][Switch] Undefined/null values in the theme causes crash #42113

Open beaktor opened 2 weeks ago

beaktor commented 2 weeks ago

Steps to reproduce

https://github.com/mui/material-ui/pull/41367/files#r1586868393

I can put some effort in making an environment, but I hope the comment above is enough using code inspection to suffice for "steps to reproduce". Requested by @siriwatknp, suggested fix included in the PR comment above.

Current behavior

Themes with a undefined/null value will crash

Expected behavior

While not happy path, Switch should tolerate themes with a value that is undefined/null.

Context

Our application dynamically switches between themes, and some themes have extra definitions. These defs might appear as null when it's not relevant. This recent change chokes on that change.

Your environment

npx @mui/envinfo ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ```

Search keywords: switch theme undefined null crash

mnajdova commented 4 days ago

@siriwatknp a quick reminder to look into this.