search

mui / material-ui

MaterialĀ UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
91.86k stars 31.57k forks source link

[docs][customization-color] Slider twitch issue solved #42119

Open Nashyn opened 2 weeks ago

Nashyn commented 2 weeks ago

Fixes https://github.com/mui/material-ui/issues/42019

There were conflicting css issues that was preventing the slider from working smoothly when going from left to right or right to left and causing twitch after 100 and 50.

The issue is now solved as shown in the video below:

https://github.com/mui/material-ui/assets/137361980/66293d66-6a72-496f-a255-77f15a8702f8

mui-bot commented 2 weeks ago

Netlify deploy preview

https://deploy-preview-42119--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against b5ce5b01c7d12af55451a5004e57314633cab59d

Nashyn commented 1 week ago

@mj12albert can you please look at the changes whenever you get a chance.

mj12albert commented 5 days ago

@mj12albert can you please look at the changes whenever you get a chance.

@Nashyn Thanks for working on this! I will review this today

mj12albert commented 5 days ago

@Nashyn Your changes does indeed fix the issue šŸ‘

Just wondering how you found the fix and if you have tried other alternatives - it would be preferable if this could be fixed without using magic numbers ~

Nashyn commented 4 days ago

@mj12albert I found the fix while inspecting and trying roundabouts with slider css and saw a twitch was occuring due to conflicting styles. I have committed the changes you asked for if the solution works without magic number. Can you please review it. Thank you.