search

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
92.04k stars 31.64k forks source link

[material-ui][Autocomplete] Improve design when there's a start adornment for small autocomplete (@TahaRhidouani) #42176

Closed github-actions[bot] closed 3 weeks ago

github-actions[bot] commented 3 weeks ago

Cherry-pick of #41781

mui-bot commented 3 weeks ago

Netlify deploy preview

https://deploy-preview-42176--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 092881231bdbdd081ec38c508d3ca07354004a00

DiegoAndai commented 3 weeks ago

I'm not sure it was necessary to cherry-pick this 🤔 We should only cherry-pick urgent fixes.

Was there a particular reason to do it?

ZeeshanTamboli commented 3 weeks ago

I'm not sure it was necessary to cherry-pick this 🤔 We should only cherry-pick urgent fixes.

Was there a particular reason to do it?

The user is using Material UI version 5. I wasn't aware that only urgent fixes, like regressions, are allowed to be cherry-picked. I think we should continue to support fixes on v5 at least until v6 is close to a stable release (maybe by the end of the beta phase?). Developers won't be migrating so early in production applications. From my experience working on GitHub issues, I've seen developers still migrating from v4 to v5. What are your thoughts?

DiegoAndai commented 2 weeks ago

I think we should continue to support fixes on v5 at least until v6 is close to a stable release

Yeah, you're right. Let's go with that.