search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.09k stars 32.33k forks source link

[material-ui] Deprecate system props #42259

Open siriwatknp opened 6 months ago

siriwatknp commented 6 months ago

The RFC https://github.com/mui/material-ui/issues/41539

Search keywords:

maapteh commented 1 week ago

@siriwatknp is it for material ui maybe nice to support eslint rules which gives a warning when having something which will break in a next major? For example React Query has an own plugin where you can set the options like "@tanstack/query/no-deprecated-options": "error",. It creates a far nicer DX since most of the libs i will not check weekly for all updates paths or RFC's.

Darksoulsong commented 3 days ago

@siriwatknp Hi, I'm having trouble determining which "system props" are being deprecated. Could you help me with this?

Based on the packages/mui-codemod/src/v6.0.0/system-props/removeSystemProps.js file, can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

oliviertassinari commented 3 days ago

@maapteh Right, I'm reopening, I see that we have one of the checkboxes unticked:

SCR-20241127-okxy

can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

@Darksoulsong I believe this was the intent, yes.

siriwatknp commented 2 days ago

@siriwatknp Hi, I'm having trouble determining which "system props" are being deprecated. Could you help me with this?

Based on the packages/mui-codemod/src/v6.0.0/system-props/removeSystemProps.js file, can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

That's correct.