search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.51k stars 32.18k forks source link

[mui-system][material-ui][Grid v2] Stabilize API #42761

Closed DiegoAndai closed 2 months ago

DiegoAndai commented 3 months ago

What's the problem?

The Grid v2 component is marked as unstable. With the addition of the Pigment Grid, a stable no-runtime alternative with the same API, we should mark the Grid v2 as stable.

Also, with three separate grid components, I worry it might get confusing to know which one to choose for users

Solution

Stabilize Grid v2 and deprecate Grid, making Grid v2 the option for runtime Grid.

Search keywords: gridv2 unstable grid

DiegoAndai commented 3 months ago

On hold: https://github.com/mui/material-ui/pull/42742

stunaz commented 3 months ago

hmm I saw component being built in pigment-css, which I didn't expect. I thought those component will be part of base-ui, and that material-ui & joy-ui will use them or reexport them if needed.

siriwatknp commented 3 months ago

I prefer making Grid v2 stable in v6 (without renaming the name) and deprecating the Grid v1.

I think it's the right time to get rid of the Grid v1 because the v2 is using gap by default thanks to @DiegoAndai. It's much better and I think the community will like it.

For the docs, I think we can swap so /material-ui/react-grid presents the new Grid and /material-ui/react-deprecated-grid presents Grid v1.

DiegoAndai commented 3 months ago

I prefer making Grid v2 stable in v6 (without renaming the name) and deprecating the Grid v1.

For the docs, I think we can swap so /material-ui/react-grid presents the new Grid and /material-ui/react-deprecated-grid presents Grid v1.

I agree, this approach makes sense 👍🏼

oliviertassinari commented 2 months ago

Is #42000 about the same issue?

siriwatknp commented 1 month ago

Is #42000 about the same issue?

Yes, I'm closing it.