Open oliviertassinari opened 3 months ago
The plan looks good overall, @oliviertassinari 👌🏼
The only step I'm not sure of is:
- Reexport Grid v2 from @mui/system/Grid2 getting one step closer to move everyone imports from @mui/material to mui/system #40594
I don't know the long-term vision for the system package, and we need to solve that before setting the goal of moving everyone to import Grid from it. This is not the issue to discuss this. @aarongarciah and @colmtuite should probably lead the discussion.
The only step I'm not sure of is: 2. Reexport Grid v2 from […]
@DiegoAndai Alright, I have removed that step.
Since this new Grid has been here for about 6 months but we haven't completed the work, and since we can't start anything new until we finish what we started (so we only start things we have the bandwidth to see through), I have tried to help a bit with step 3. in https://github.com/mui/mui-private/pull/685.
I have struggled a bit, it was frustrating, I think that we have clear opportunities to turn this into a great DX. I believe we could:
<Grid2 item>
. It says:I think we need a custom prop type instead, that clearly explain that this is a Grid v1 prop, that you can now remove the prop.
<Grid2 xs={12}>
. The attribute gets silently applied to the DOM:[ ] c. I got the impression that the migration guide was started but not finished: https://mui.com/material-ui/migration/migration-grid-v2/. I couldn't rely a lot on it. The problems I saw:
xs
, sm
, etc. props.
Summary
We recently made Grid v2 stable, #43054 so now it's time to look at the rollout plan, effectively to get completely get rid of the old one.
A possible action plan:
@mui/system/Grid2
getting one step closer to move everyone imports from @mui/material to mui/system #40594~Motivation
Simplicity