mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.03k stars 32.3k forks source link

[material-ui][theme] Wrong `cssVariables` type in Theme interface #43607

Closed tomasnikl closed 2 months ago

tomasnikl commented 2 months ago

Steps to reproduce

Link to live example

Current behavior

wrong Theme interface. cssVariables should be boolean, not false.

export interface Theme extends BaseTheme, CssVarsProperties {
  cssVariables?: false;
  components?: Components<BaseTheme>;
  unstable_sx: (props: SxProps<Theme>) => CSSObject;
  unstable_sxConfig: SxConfig;
}

Expected behavior

export interface Theme extends BaseTheme, CssVarsProperties {
  cssVariables?: boolean;
  components?: Components<BaseTheme>;
  unstable_sx: (props: SxProps<Theme>) => CSSObject;
  unstable_sxConfig: SxConfig;
}

Context

No response

Your environment

npx @mui/envinfo ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ```

Search keywords: theme, cssVariables, createTheme, css, variables

siriwatknp commented 2 months ago

@tomasnikl Thanks for the feedback. What issue have you experienced?

github-actions[bot] commented 2 months ago

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.