mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.95k stars 32.27k forks source link

With Pigment CSS, it's unclear how to manually switch palette mode (light / dark) #44384

Open aleksei-berezkin opened 3 days ago

aleksei-berezkin commented 3 days ago

Steps to reproduce

Link to live example: https://github.com/aleksei-berezkin/mui-pigment-example/

Steps:

  1. Try to find some info in MUI migration guide — no info
  2. According to Pigment CSS Readme, try to add getSelector somewhere in theme created in next.config.ts

Current behavior

Expected behavior

There should be a documented way to switch themes manually

Context

No response

Your environment

System:
  OS: macOS 14.0
Binaries:
  Node: 20.14.0 - /opt/homebrew/opt/node@20/bin/node
  npm: 10.7.0 - /opt/homebrew/opt/node@20/bin/npm
  pnpm: 9.11.0 - /opt/homebrew/opt/node@20/bin/pnpm
Browsers:
  Chrome: 130.0.6723.117
  Edge: Not Found
  Safari: 17.0
npmPackages:
  @emotion/react: ^11.13.3 => 11.13.3 
  @emotion/styled: ^11.13.0 => 11.13.0 
  @mui/core-downloads-tracker:  6.1.6 
  @mui/material: ^6.1.6 => 6.1.6 
  @mui/material-pigment-css: ^6.1.6 => 6.1.6 
  @mui/private-theming:  6.1.6 
  @mui/styled-engine:  6.1.6 
  @mui/system:  6.1.6 
  @mui/types:  7.2.19 
  @mui/utils:  6.1.6 
  @pigment-css/nextjs-plugin: ^0.0.26 => 0.0.26 
  @pigment-css/react:  0.0.25 
  @pigment-css/unplugin:  0.0.26 
  @types/react: ^18.3.1 => 18.3.12 
  react: ^18.3.1 => 18.3.1 
  react-dom: ^18.3.1 => 18.3.1 
  typescript: ^5.6.3 => 5.6.3 

Search keywords: Pigment, material-pigment-css, palette mode

siriwatknp commented 3 days ago

I am putting this issue to high priority.

oliviertassinari commented 2 days ago

I guess we should transfer this issue to https://github.com/mui/pigment-css? I mean why should it be any different in Material UI compared to in Pigment CSS https://github.com/mui/pigment-css?tab=readme-ov-file#switching-color-schemes?