mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.02k stars 32.3k forks source link

[icons] Improve icon search performance #44450

Open oliviertassinari opened 4 days ago

oliviertassinari commented 4 days ago

This is a continuation of #44001. I'm not sure that that change actually had any positive impact. I suspect that it only surfaced a Chrome DevTools bug that it works around.

Instead, what we see now is https://pagespeed.web.dev/analysis/https-mui-com-material-ui-material-icons/cvfn967l26?form_factor=desktop. That INP is horrible.

SCR-20241118-dtts

What I'm doing instead is moving #44025 to the finish line. I used a different search dependency at the same time. It seems smaller, faster, and a bit more accurate.

I was curious to check how other icons libraries handle this:

Preview: https://deploy-preview-44450--material-ui.netlify.app/material-ui/material-icons/

mui-bot commented 4 days ago

Netlify deploy preview

https://deploy-preview-44450--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against e52845e52c85416cf9256146f9f7eb478eeae3b4