[Button] Fix `CircularProgress` import - Githubissues

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.

https://mui.com/material-ui/

MIT License

94.02k stars 32.3k forks source link

[Button] Fix `CircularProgress` import #44473

Closed siriwatknp closed 2 days ago

siriwatknp commented 2 days ago

Proptypes are updated based on comments in https://github.com/mui/material-ui/pull/42987#discussion_r1844135928

[x] I have followed (at least) the PR section of the contributing guide.

mui-bot commented 2 days ago

Netlify deploy preview

docs/data/material/components/buttons/buttons.md

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 4112e8f5cefe6f63c44a372ec61f6324cc831f59

oliviertassinari commented 2 days ago

What if we were to have this in the eslint config? https://github.com/mui/material-ui/pull/42987#discussion_r1849371939. Effectively, it seems that we have good reason to do https://github.com/mui/mui-x/blob/340acbde76bbad3d7925f3c374cb9f23a8d7f924/.eslintrc.js#L57 now (MUI X is head here).