search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.02k stars 32.3k forks source link

[material-ui][Button] Revert Button loading #44478

Closed siriwatknp closed 1 day ago

siriwatknp commented 1 day ago

To add loading to the Button, it's required to wrap the text with another span element to prevent Google translation crash so it's a breaking change.

The work can be revisited in v7.

mui-bot commented 1 day ago

Netlify deploy preview

IconButton: parsed: -4.33% :heart_eyes:, gzip: -3.45% :heart_eyes: Alert: parsed: -3.84% :heart_eyes:, gzip: -2.94% :heart_eyes: Autocomplete: parsed: -2.38% :heart_eyes:, gzip: -1.78% :heart_eyes: @material-ui/core: parsed: -0.58% :heart_eyes:, gzip: -0.41% :heart_eyes: LoadingButton: parsed: +1.16% , gzip: +0.38% @material-ui/lab: parsed: +0.14% , gzip: -0.02% :heart_eyes:

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 767a9bc7efbd5b73d947872167c53d1001466c24

michaldudak commented 1 day ago

@zannager, since I don't work on Material UI, someone from the Core team might have better insights on the topic.