search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
94.02k stars 32.3k forks source link

[core-infra] Add no-relative-packages #44489

Open oliviertassinari opened 1 day ago

oliviertassinari commented 1 day ago

Move https://github.com/mui/mui-x/pull/15437 from MUI X to code-infra.

This breaks in Base UI. Some are nice, they show cases where we import private APIs in the app/experiments some are weird, e.g. https://github.com/mui/base-ui/blob/d7809157ccc737608acc70a1ecbb42dfbca7ae78/packages/mui-base/vitest.config.ts#L2 seems fine.

mui-bot commented 1 day ago

Netlify deploy preview

https://deploy-preview-44489--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against b0d8dd4425df58461f4cf00946e0d4e466e9e851

Janpot commented 1 day ago

It seems fine.

it mostly is, the main problem I've seen so far is that it stops us from being able to rely on workspace topology to detect changes. e g. to run tests selectively. for things like the vitest config, we could always place those in their own package.