search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.38k stars 32.14k forks source link

bundle jsx and react-tools as dev-dependencies #616

Closed mderazon closed 9 years ago

mderazon commented 9 years ago

running

$ npm run build

relies on the user to have jsx and react-tools installed globally.

IMO it's much better to bundle them locally in package.json. This way the command will run without any external dependencies.

hai-cea commented 9 years ago

@mderazon I show react-tools is a dev-dependency in the package.json?

https://github.com/callemall/material-ui/blob/master/package.json#L40

mderazon commented 9 years ago

My bad, you're right.

For some reason, it didn't build when I tried it. Tried it again and it seems fime