search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.61k stars 32.21k forks source link

SelectField id does not appear in event.target.id (v0.19.4) when Select field is clicked #8601

Closed serle closed 7 years ago

serle commented 7 years ago

The SelectField does not seem to pass its id property to the correct internal domNode. This cause there to be no event.target.id set in the click event. I can however retrieve the id from the click event using event.target.parenNode.parentNode.id

oliviertassinari commented 7 years ago

Does it work with currentTarget?

oliviertassinari commented 7 years ago

I'm afraid there is nothing I can do about it. If you find a solution, we will be happy to review a pull request on the master branch. Otherwise, I'm closing.

serle commented 7 years ago

Does not work with currentTarget either. When I get a chance I'll look at which element is the click target and see why the id property is not being set there. I'm waiting for the DateField to be added to 1.0.0 then I think you have all the components I will need to start the upgrade process. In the meantime I'm stuck on the v19 version.

oliviertassinari commented 7 years ago

@serle Migrating one component at the time isn't an option for you?

serle commented 7 years ago

@oliviertassinari theming and styling look different between the two libraries, so I decided to wait for v1 to catch up and do the transform in one go. I have not found much wrong with v19, however I am looking forward to converting to v1 at the right moment.