search

mui / mui-design-kits

The public feature and bug tracker for the MUI Design kits and Connect Figma plugin.
https://mui.com/design-kits/
116 stars 17 forks source link

[sync] `_states` does not exist in type `PaletteColorOptions & Partial<PaletteColorChannel>` #382

Open devleejb opened 3 months ago

devleejb commented 3 months ago

Steps to reproduce

Link to live example:

Steps:

  1. Export theme from Material UI Sync Plugin
  2. Apply it to the source code
  3. Check whether the _states are applied

Current behavior

  1. _states does not exist in type PaletteColorOptions & Partial<PaletteColorChannel>

    image

  2. The color isn't applied. (This screenshot is button.)

    image

Expected behavior

  1. _states are applied correctly.
  2. The colors are applied correctly.

Context

No response

Your environment

Software Version
Design file version v5.16.0
Design tool Figma
etc.

Search keywords: _states

adrianmanea commented 3 months ago

Hi, as stated in the Figma docs "_states" group is only available in Figma. Simply omit everything that starts with an underscore.

devleejb commented 3 months ago

@adrianmanea Some colors references the value in _states.

"background": "var(--mui-palette-primary-_states-hover)"

Then, how can use the color using MUI Sync Plugin?

adrianmanea commented 3 months ago

Can you please send an email at figma@mui.com with your Figma order ID so I send you the latest version, I think MUI Sync ignores the "_states" group when using the 5.17.0 library.

devleejb commented 3 months ago

@adrianmanea I sent the mail. Please check it. Thank you!

rown89 commented 2 months ago

There is any chance to handle _states in the 5.17.0 library? MUI Sync generates classes who take care of _states variables but their values produce bugs.

devleejb commented 2 months ago

It is not resolved in 5.17.0.

image
yoandry-quantifi commented 1 month ago

I'm facing the same issue in the latest MUI v5 image

devleejb commented 1 week ago

@adrianmanea Any updates so far?

adrianmanea commented 1 week ago

Hi, @devleejb the plugin development is currently on hold, we recommend using it only for basic overwrites and manually modify when it's wrong.