search

mui / mui-public

The public mono-repository of MUI (as an organization), see mui/mui-private for the opposite.
80 stars 16 forks source link

[bug] Running `yarn` in `tools-public` throws on Windows #101

Open mnajdova opened 1 year ago

mnajdova commented 1 year ago

Navigate to tools-public and run yarn. I got the following error:

[5/5] Building fresh packages...
[-/4] ⠐ waiting...
[2/4] ⠈ esbuild
[3/4] ⠈ cpu-features
warning Error running install script for optional dependency: "D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features: Command failed.
Exit code: 1
Command: node buildcheck.js > buildcheck.gypi && node-gyp rebuild
Arguments:
Directory: D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features
Output:
D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133
        throw new Error('Unable to detect compiler type');
        ^

Error: Unable to detect compiler type
    at new BuildEnvironment (D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133:15)
    at Object.<anonymous> (D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features\\buildcheck.js:5:12)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
warning Your current version of Yarn is out of date. The latest version is "1.22.19", while you're on "1.22.5".
info To upgrade, download the latest installer at "https://yarnpkg.com/latest.msi".
Done in 360.69s.

OS used: Windows yarn version: 1.22.5

I could still do yarn dev and run it locally, haven't noticed some issues.

Janpot commented 1 year ago

Looks like it gets pulled in through ssh2. It seems to be an optional dependency. It says warning, and the install command finished with a 0 exit code, so I assume the installation went fine and this can just be ignored. If ssh2 marks this as optional I guess it will detect whether the installation happened correctly before using the dependency.

Janpot commented 1 year ago

@mnajdova When you have a moment, could you try on the latest master? I've updated the transitive dependencies. I noticed they recently had some updates around windows support.