search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.16k stars 1.3k forks source link

[pickers][DateTimePicker] not showing 2 in the hour category, but shows 3 twice and the first isn't selectable #12403

Open kyle-rachau opened 7 months ago

kyle-rachau commented 7 months ago

Steps to reproduce

Link to live example: (required)

https://mui.com/x/react-date-pickers/date-time-picker/

Steps:

  1. any date time picker, even the demos on the mui site are broke

Current behavior

The hour category shows 12-1-3-3-4-5

Expected behavior

The hour category shows 12-1-2-3-4-5

Context

Select time from date time picker image

Your environment

npx @mui/envinfo ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ```

Search keywords: DateTimePicker hour Order ID: 39752

atrauzzi commented 7 months ago

Screencast from 2024-03-10 16-00-23.webm

I'm wondering if this has anything to do with daylight savings, which is today?

The video above is taken from https://mui.com/x/react-date-pickers/time-picker/

kyle-rachau commented 7 months ago

Yea that was my guess too.

michelengelen commented 7 months ago

Hey @atrauzzi could you tell me which timezone you are in? I cannot reproduce the issue, but I guess this could be due to a timezone issue (since different zones have different dates for the DST change)

kyle-rachau commented 7 months ago

It seems to work this morning, but can't edit the previous day. It must have just been a DST change.

michelengelen commented 7 months ago

Still ... I would like to investigate this, as this is clearly a bug, even if it only happens on a single day in the year. 🤔

LukasTy commented 7 months ago

This looks like a similar topic to https://github.com/mui/mui-x/issues/10783. I'll look into it, whenever I get back to finalizing the PR for DigitalClock. 👌

atrauzzi commented 7 months ago

@michelengelen "America/Winnipeg" :+1:

flaviendelangle commented 7 months ago

@LukasTy do you want to mark that one as duplicate?

LukasTy commented 7 months ago

@LukasTy do you want to mark that one as duplicate?

Not sure that it can be treated as a duplicate. 🤔 The mentioned one concerns the DigitalClock component, whereas this one is about MultiSectionDigitalClock and TimeClock. 🤔

flaviendelangle commented 7 months ago

If you think the two fixes will be handled independently then we can add this one to the board as well :+1: