[DataGrid] Fix rows not being recomputed on `props.rowCount` change

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!

https://mui.com/x/

3.79k stars 1.12k forks source link

[DataGrid] Fix rows not being recomputed on `props.rowCount` change #12833

Closed MBilalShafi closed 1 day ago

MBilalShafi commented 2 weeks ago

Fixes #12769

Also tested in this repo: https://github.com/MBilalShafi/test-mui-x-12833 Seems to work as expected.

mui-bot commented 2 weeks ago

Deploy preview: https://deploy-preview-12833--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against ba4124b5cebaf93dbbe017514922ff4dc62e3743

cherniavskii commented 3 days ago

Before: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-dt6nxy After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-v4x3jd

@MBilalShafi Can you confirm the behavior in the "After" demo is correct?

MBilalShafi commented 3 days ago

Yes, it looks correct. Thanks @cherniavskii for creating the sandboxes.