search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
3.79k stars 1.12k forks source link

[data grid] Sorting Removes Filtering #12854

Closed lisaWriteJava closed 1 week ago

lisaWriteJava commented 1 week ago

The problem in depth

If I filter this table, then sort on another column, the filtering disappears and all the rows reappears. This is the code sandbox link: https://codesandbox.io/p/sandbox/sortandfilter-3vgm33?file=%2Fsrc%2FEntityLink.jsx%3A2%2C37

Your environment

`npx @mui/envinfo` ``` Chrome Browser System: OS: Linux 3.10 CentOS Linux 7 (Core) Binaries: Node: 16.20.0 - ~/.nvm/versions/node/v16.20.0/bin/node npm: 7.24.2 - ~/node_modules/.bin/npm pnpm: Not Found Browsers: Chrome: 120.0.6099.71 npmPackages: @emotion/react: latest => 11.11.3 @emotion/styled: latest => 11.11.0 @mui/base: 5.0.0-beta.32 @mui/core-downloads-tracker: 5.15.5 @mui/icons-material: ^5.15.3 => 5.15.5 @mui/lab: ^5.0.0-alpha.159 => 5.0.0-alpha.161 @mui/material: ^5.15.3 => 5.15.5 @mui/private-theming: 5.15.5 @mui/styled-engine: 5.15.5 @mui/styles: ^5.15.3 => 5.15.5 @mui/system: 5.15.5 @mui/types: 7.2.13 @mui/utils: ^5.15.4 => 5.15.5 @mui/x-data-grid: 6.19.1 @mui/x-data-grid-generator: ^6.16.2 => 6.19.1 @mui/x-data-grid-premium: ^6.19.1 => 6.19.1 @mui/x-data-grid-pro: 6.19.1 @mui/x-license-pro: ^6.10.2 => 6.10.2 @types/react: 17.0.75 react: ^17.0.2 => 17.0.2 react-dom: ^17.0.2 => 17.0.2 styled-components: latest => 6.1.8 ```

Search keywords: filtering sorting Order ID: 66765

lisaWriteJava commented 1 week ago

In sandbox it seems to work as expected but in our code base sorting on a column other than the filtered one the filter is removed. I think it is the setup of the initial state wit filtering and sorting and the sort model

michelengelen commented 1 week ago

@lisaWriteJava Your guess seems about right. That would be the most logical cause for the described behavior.

Could you try replicating this as minimal as possible in the sandbox? As you already mentioned the current one seems to work as expected, so we cannot help you with this until we see the implementation and bug happening.

lisaWriteJava commented 1 week ago

I think that I figured it out. I had set the initial sort, on sort change and filterPanel and filter model, once I removed those all went well.

lisaWriteJava commented 1 week ago

I'm continnuing to test to see if the issue happens again.

lisaWriteJava commented 1 week ago

After making the changes. All has been good. I think that we can close the ticket

On Mon, Apr 22, 2024, 6:38 AM Michel Engelen @.***> wrote:

@lisaWriteJava https://github.com/lisaWriteJava Your guess seems about right. That would be the most logical cause for the described behavior.

Could you try replicating this as minimal as possible in the sandbox? As you already mentioned the current one seems to work as expected, so we cannot help you with this until we see the implementation and bug happening.

— Reply to this email directly, view it on GitHub https://github.com/mui/mui-x/issues/12854#issuecomment-2069057235, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMQONWZ5NTOPEJZIHHXGTY6TSATAVCNFSM6AAAAABGPKRCBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZGA2TOMRTGU . You are receiving this because you were mentioned.Message ID: @.***>

michelengelen commented 1 week ago

Ok, great! Thanks for letting us know! 👍🏻

github-actions[bot] commented 1 week ago

:warning: This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@lisaWriteJava: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.