search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.02k stars 1.24k forks source link

[pickers] heading level 2 is missing on dialog for calendar/date picker - 508 issue #12872

Open skatiyar12 opened 4 months ago

skatiyar12 commented 4 months ago

Steps to reproduce

Expected Result: heading level 2 should be present on dialog that opens rendering calendar

Actual Result: heading level 2 is missing on dialog

Screen shot attached: image

image

Current behavior

When we click on the date picker icon. Modal with calendar opens, however there is no h2 heading on this modal, which is a 508 issue.

Expected behavior

Modal should have h2 heading. Current selected date should be h2.

Context

We are using version 5.0.20. We would appreciate if a fix can be provided on this version.

Your environment

npx @mui/envinfo ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ```

Search keywords: calendar/datepicker 508 issue

michelengelen commented 4 months ago

Hey @skatiyar12 ... @noraleonte will take care of that! Thanks for raising an issue for this! 🙇🏼

noraleonte commented 4 months ago

Hey 👋 Thanks for opening the issue. It's definitely a valid point, I see multiple examples using the dialog with a level 2 heading, even though it's not explicitly specified. However, considering that we plan on switching to the MD3 approach, which would have an impact on this issue, I'm putting it up for grooming so we can talk more about the implications of this 👌