search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
3.82k stars 1.13k forks source link

[charts] Fix docs/translations/errors typos #12941

Closed JCQuintas closed 3 weeks ago

JCQuintas commented 3 weeks ago

I just ran cspell on the x-charts folder and fixed what didn't look like intentional 😅

mui-bot commented 3 weeks ago

Deploy preview: https://deploy-preview-12941--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against 4bf4bffbc2799a01a96bc7458a17318cf41c1722

JCQuintas commented 3 weeks ago

Have you considered running it in CI? Is it fast?

Didn't consider, but should be pretty simple to run in CI, and yes it is fast. I just think it needs to be a bit more thoughtful process. Because it flags a lot of "fake/tech" words as "wrong". Eg: Stackable, while not necessarily correct, conveys the correct meaning. So we would have to add those to an "allow list"

Does it have a way to be run only on changes compared to a branch (i.e. like we do with prettier)?

I believe you can do that with anything using some shell scripting magic 😛