search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.13k stars 1.28k forks source link

[LineChart] Latest version prints React warnings #13611

Open Janpot opened 3 months ago

Janpot commented 3 months ago

Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/billowing-fog-39pdzs?file=%2Fsrc%2FDemo.tsx

Steps:

  1. Open the example
  2. Check the console

Current behavior

It prints 

Warning: Unknown event handler property `onAreaClick`. It will be ignored.
...

and

Warning: Unknown event handler property `onMarkClick`. It will be ignored.
...

Expected behavior

No warnings printed

Context

Discovered because it broke the Toolpad tests during last renovate upgrade cycle: https://app.circleci.com/pipelines/github/mui/mui-toolpad/15000/workflows/7cb28836-1265-47b2-838d-9dc1d8376bf5/jobs/69929?invite=true#step-106-25841_89

Would recommend setting up the tests to catch these warnings by default.

Your environment

npx @mui/envinfo ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ```

Search keywords: onMarkClick

Janpot commented 3 months ago

Additionally, the stackblitz is broken for that demo.

alexfauquette commented 3 months ago

The error got fixed today in #13609

But I keep the issue open until we add the testing script

si-saaref commented 3 months ago

I'm still facing this error.. Is the bug already got fixed or not?

alexfauquette commented 3 months ago

The fxed version should be published during the day