mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.52k stars 1.31k forks source link

[data grid] Any opened group by rows is automatically closed before printing #14023

Open VictimCrasher opened 3 months ago

VictimCrasher commented 3 months ago

Steps to reproduce

Link to live example: https://codesandbox.io/s/stoic-shannon-c246cm

Steps:

  1. Expand one of the group by
  2. Click export > print

Current behavior

Expanded rows are closed before printing, making it impossible to print any row group view

https://github.com/user-attachments/assets/0a9fdd44-9531-429e-9e4e-b173d443aef3

Expected behavior

Compared to v6, the opened row is retained on print preview: https://codesandbox.io/s/gifted-sea-35vr89

https://github.com/user-attachments/assets/e08afc83-6469-44bf-955f-120361d68cc9

Context

I have a Datagrid with row grouping and filter enabled by default, but the user now cannot print the grouped data I initially thought it's due to rerendering but it seems it's not the case

Although it seems related with this issue in one way or another https://github.com/mui/mui-x/issues/13962

Your environment

npx @mui/envinfo ``` System: OS: Windows 10 10.0.19045 Binaries: Node: 14.19.0 - C:\Program Files\nodejs\node.EXE npm: 6.14.16 - C:\Program Files\nodejs\npm.CMD pnpm: Not Found Browsers: Chrome: 126.0.6478.185 Edge: Chromium (127.0.2651.74) npmPackages: @emotion/react: ^11.10.5 => 11.10.6 @emotion/styled: ^11.10.5 => 11.10.6 @mui/base: ^5.0.0-alpha.101 => 5.0.0-alpha.125 @mui/core-downloads-tracker: 5.16.0 @mui/icons-material: ^5.11.9 => 5.11.16 @mui/lab: ^5.0.0-alpha.103 => 5.0.0-alpha.126 @mui/material: ^5.15.14 => 5.16.0 @mui/private-theming: 5.16.0 @mui/styled-engine: 5.15.14 @mui/styles: ^5.15.14 => 5.16.0 @mui/system: ^5.15.14 => 5.16.0 @mui/types: 7.2.4 @mui/utils: 5.12.0 @mui/x-data-grid-premium: ^7.0.0 => 7.9.0 @mui/x-date-pickers: ^7.0.0 => 7.9.0 @mui/x-date-pickers-pro: ^7.0.0 => 7.9.0 @mui/x-internals: 7.9.0 @mui/x-license: ^7.0.0 => 7.9.0 @mui/x-tree-view: ^7.9.0 => 7.9.0 @types/react: 18.0.35 react: ^18.2.0 => 18.2.0 react-dom: ^18.2.0 => 18.2.0 styled-components: 5.3.9 typescript: 4.9.5 ```

Search keywords: export, grouping

MBilalShafi commented 3 months ago

Thank you @VictimCrasher for reporting. I can confirm this is a regression from v6. Added to the queue of issues to be prioritized.