mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.17k stars 1.3k forks source link

[data grid] `onColumnOrderChange` not triggered in Firefox because `event.dataTransfer` is null #14263

Closed DaryaHaprova closed 3 weeks ago

DaryaHaprova commented 2 months ago

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-zvxe1b?file=Demo.js Steps:

  1. Try to reorder columns by drag and drop
  2. check console
  3. 'order change' - not logged
  4. error - event.dataTransfer is null Screenshot (347) Screenshot (348)

Current behavior

onColumnOrderChange not triggered

Expected behavior

onColumnOrderChange triggered

Context

I want to save columns order in local storage on change

Your environment

npx @mui/envinfo ``` I used Firefox - 129.0.1 System: OS: Windows 10 10.0.19045 Binaries: Node: 18.16.0 - C:\Program Files\nodejs\node.EXE Yarn: Not Found npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: Not Found Edge: Chromium (127.0.2651.98) ```

Search keywords: dataTransfer, Firefox, onColumnOrderChange

michelengelen commented 2 months ago

It seems like a but that got introduced in FF v129 ... it works in v128. I am currently looking over the changelogs and bugzilla to find the cause for the change, but no luck so far.

michelengelen commented 2 months ago

I just tested it in v130 and nightly ... so it only appears in v129 ... Since v130 will release next month should we add a callout in the docs to inform users about this @mui/xgrid ?

RajeshReddyM commented 2 months ago

I experienced the same problem with version 129.0.1, but after updating Firefox this morning, it works fine with version 129.0.2.

github-actions[bot] commented 3 weeks ago

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

[!NOTE] We value your feedback @DaryaHaprova! How was your experience with our support team? We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!