search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.08k stars 1.26k forks source link

[pickers] Date picker crash on mui.com #14422

Closed oliviertassinari closed 2 weeks ago

oliviertassinari commented 3 weeks ago

Steps to reproduce

Steps:

  1. Open https://mui.com/
  2. Click on the next month button icon

Current behavior

https://github.com/user-attachments/assets/1e38a1ed-28f5-4c32-842e-4c1719c46db7

Context

https://x.com/bweston92/status/1829792875955028046

michelengelen commented 3 weeks ago

Seems related to the transition:

Screenshot 2024-09-02 at 11 48 17
michelengelen commented 3 weeks ago

The demos in the docs work... so it might be specific to some styles in this demo.

arthurbalduini commented 3 weeks ago

I did a quick investigation and there's a space being added to the SlideTransition classnames, perhaps involving the overrideResolver on the styled component, but I'm not being able to evolve much futher than that. Does anyone have more insights about it ? @LukasTy @flaviendelangle

Screenshot 2024-09-02 at 16 04 10
alexfauquette commented 3 weeks ago

If that can help, the older docs build with the bug I found is this one https://github.com/mui/material-ui/pull/43363

@romgrk could it be an unexpected side effect?

romgrk commented 3 weeks ago

Yes, @oliviertassinari has an open & approved PR to restore the behavior: https://github.com/mui/material-ui/pull/43537

oliviertassinari commented 3 weeks ago

Oh wow, I would have never expected an extra space to cause a bug like this. I guess something broken around https://github.com/reactjs/react-transition-group/blob/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/CSSTransition.js#L11. Too bad that this dependency seems unmaintained, we can't fix it there.

romgrk commented 3 weeks ago

We should also probably think about running mui-x tests in the core repo, it would make it more safe to refactor the core.

cc @mui/code-infra

Janpot commented 2 weeks ago

We should also probably think about running mui-x tests in the core repo, it would make it more safe to refactor the core.

🙂 One could almost argue that X packages and @mui/material belong in the same repository.

LukasTy commented 2 weeks ago

Looks like the issue has been resolved with this fix: https://github.com/mui/material-ui/pull/43537 and is no loner present in the deployed documentation.

github-actions[bot] commented 2 weeks ago

:warning: This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@oliviertassinari: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.