mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.53k stars 1.32k forks source link

[docs] Fix demos acting flaky in Argos #15372

Open LukasTy opened 1 week ago

LukasTy commented 1 week ago

Some demos are producing flaky results in Argos. Sometimes we approve the broken versions and then have to re-approve the proper version of those snapshots in multiple follow-up PRs. Here are examples of the latest demos producing issues: https://app.argos-ci.com/mui/mui-x/builds/26329/118165897, https://app.argos-ci.com/mui/mui-x/builds/26330/118217890.

Search keywords:

JCQuintas commented 1 week ago

Could this be an issue with the v7 branch and the config? I've run the migration scrips locally in master and v7 and the outputs are different for some of these tests

LukasTy commented 1 week ago

As far as I remember, at least he PopularFeaturesDemo was flaky before the start of the master<->v7.x "tango". 🤔

JCQuintas commented 1 week ago

Yeah, so from the argos config, it uses master as the base, so I GUESS if on a v7 PR we accept the changes, they will be the new "master" changes.

LukasTy commented 1 week ago

Yeah, so from the argos config, it uses master as the base, so I GUESS if on a v7 PR we accept the changes, they will be the new "master" changes.

Hasn't Argos been semi recently updated to work smart with the branches? 🤔

JCQuintas commented 1 week ago

Idk, their settings doesn't have anything related to that: https://app.argos-ci.com/mui/mui-x/settings

LukasTy commented 1 week ago

Idk, their settings doesn't have anything related to that: https://app.argos-ci.com/mui/mui-x/settings

@JCQuintas I was referring to https://argos-ci.com/changelog/2024-10-08-multi-branches. 😉