Open alexfauquette opened 2 days ago
Deploy preview: https://deploy-preview-15513--material-ui-x.netlify.app/
Generated by :no_entry_sign: dangerJS against 925b4e11c6b65489cb24343ee89b559464b4d1b8
Comparing alexfauquette:pluggins
(925b4e1) with master
(cac5df0)
⚡ 1
improvements
✅ 5
untouched benchmarks
Benchmark | master |
alexfauquette:pluggins |
Change | |
---|---|---|---|---|
⚡ | ScatterChartPro with big data amount |
195.3 ms | 177.9 ms | +9.78% |
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This PR brings all the typing and pipeline to support plugins in the ChartProvider.
For now the hooks only replace 2 features:
svgRef
chartId
Chart state
The main idea is to have in a provider multiple ref you can ask to interact/render the chart
instance
which contains all the methods to get/update dataplublicApi
that contains the methods we will let people usesvgRef
that already existstore
introduced in the previous PR that manage state accessible by selectors.Typing
The plugin types work as follows:
UseChartXxxSignature
which defines the state, the interface, ...ChartState<[UseChartInteractionSignature, ...]>
and it provide a type that merge the instance, and the store of the plugin signatures you listed