mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
3.94k stars 1.21k forks source link

[DataGrid] Implement Cell editing #203

Closed oliviertassinari closed 3 years ago

oliviertassinari commented 3 years ago

Benchmark

This feature is also related to the editable row #204.

raajmayukh commented 3 years ago

@oliviertassinari Can I get an idea on ETA for this enhancement? I do see that row editing is planned for Q4, so would cell editing be part of that enhancement as it's related? https://github.com/mui-org/material-ui-x/projects/1

oliviertassinari commented 3 years ago

@raajmayukh We are focusing on #201. This one will probably land in 2021.

rgins16 commented 3 years ago

@oliviertassinari Are you planning on implementing this for columns as well? I would like to change the headerName.

oliviertassinari commented 3 years ago

@rgins16 We won't handle the header in the first iteration. I can't say for the following ones. The most common use case is to change the cells, only. So far, we plan this feature for Q1 2021.

Samurus commented 3 years ago

@oliviertassinari I miss primefaces/primereact in the list for Benchmark: https://primefaces.org/primereact/showcase/#/datatable/edit It seems to be free and open source which is a great plus.

oliviertassinari commented 3 years ago

@Samurus Thanks for linking the reference to primeface. Mind that the plan is to make this feature in the MIT version: https://material-ui.com/components/data-grid/getting-started/#feature-comparison.

arheinjohnson commented 3 years ago

Any idea how soon this will be implemented?

dtassone commented 3 years ago

We have merged the last PR for the implementation. We still have to finish the documentation, and if it all goes well it should be released next week or the week after.

raajmayukh commented 3 years ago

@oliviertassinari @dtassone Thanks guys for tackling that. I know I had reached out in November last year for this feature and subsequently implemented through react-table. But this is something that I would check to see if this one works even better. Thanks again. Cheers!!

angelhd1999 commented 3 years ago

We have merged the last PR for the implementation. We still have to finish the documentation, and if it all goes well it should be released next week or the week after.

@dtassone I've been doing a project with Material-UI for some time and if I can take advantage of this it would be great. Could you tell me if cell editing will allow advanced ways of editing like selecting between different options or a date picker? I ask it to know if I have to think of a different approach or it is worth waiting for me. Thank you very much for the effort you make.

khanzzirfan commented 3 years ago

Just FYI: I have used the alpha release of the cell edit feature. Its looks good. Thank you for the support. But below are few things doesn't work.

oliviertassinari commented 3 years ago

@khanzzirfan Related to #1320. If you have a reproduction, please open a new issue.

oliviertassinari commented 3 years ago

The documentation for this feature can now be found at https://material-ui.com/components/data-grid/editing/#cell-editing.