mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
4.17k stars 1.3k forks source link

XGrid GridToolbarFilterButton typescript definition bug #2217

Closed jb-thery closed 3 years ago

jb-thery commented 3 years ago

Hello, I found a typescript issue with GridToolbarFilterButton :

  "@material-ui/x-grid": "^4.0.0-alpha.34",

https://i.ibb.co/sv8KNQ7/Capture-d-e-cran-2021-07-26-a-19-18-17.png

flaviendelangle commented 3 years ago

Could you please follow the "Your Environment" part of the issue creation process ?

## Your Environment 🌎

<!--
  Run `npx @material-ui/envinfo` and post the results.
  If you encounter issues with TypeScript please include the used tsconfig.
-->
<details>
  <summary>`npx @material-ui/envinfo`</summary>

  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.

</details>

I'm not reproducing your issue.

I think it the same problem as https://github.com/mui-org/material-ui-x/issues/2000

jb-thery commented 3 years ago

hello, all right :

System:
    OS: macOS 11.5
  Binaries:
    Node: 16.5.0 - ~/.nvm/versions/node/v16.5.0/bin/node
    Yarn: Not Found
    npm: 7.19.1 - ~/.nvm/versions/node/v16.5.0/bin/npm
  Browsers:
    Chrome: 92.0.4515.107
    Edge: Not Found
    Firefox: Not Found
    Safari: 14.1.2
  npmPackages:
    @emotion/react: ^11.4.0 => 11.4.0 
    @emotion/styled: ^11.3.0 => 11.3.0 
    @material-ui/core: ^5.0.0-beta.2 => 5.0.0-beta.2 
    @material-ui/data-grid: ^4.0.0-alpha.34 => 4.0.0-alpha.34 
    @material-ui/icons: ^5.0.0-beta.1 => 5.0.0-beta.1 
    @material-ui/lab: ^5.0.0-alpha.41 => 5.0.0-alpha.41 
    @material-ui/private-theming:  5.0.0-beta.2 
    @material-ui/styled-engine:  5.0.0-beta.1 
    @material-ui/styled-engine-sc: ^5.0.0-alpha.11 => 5.0.0-alpha.11 
    @material-ui/styles: ^5.0.0-beta.2 => 5.0.0-beta.2 
    @material-ui/system:  5.0.0-beta.2 
    @material-ui/types:  6.0.1 
    @material-ui/unstyled:  5.0.0-alpha.41 
    @material-ui/utils:  5.0.0-beta.1 
    @material-ui/x-grid: ^4.0.0-alpha.34 => 4.0.0-alpha.34 
    @material-ui/x-license:  4.0.0-alpha.34 
    @types/react: ^17.0.15 => 17.0.15 
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    styled-components: ^5.3.0 => 5.3.0 
    typescript: ^4.3.5 => 4.3.5 

ts-config :

{
  "compilerOptions": {
    "target": "ESNext",
    "lib": ["DOM", "DOM.Iterable", "ESNext"],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "noFallthroughCasesInSwitch": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "ESNext",
    "moduleResolution": "Node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react",
    "baseUrl": ".",
    "paths": {
      "@/*": ["./src/*"],
      "@@/*": ["./src/.vit/*"]
    }
  },
  "include": ["./src"]
}

package.json :

"scripts": {
    "dev": "vite",
    "build": "tsc && vite build",
    "serve": "vite preview",
    "eslint": "npx eslint .",
    "husky:prepare": "husky install"
  },
  "dependencies": {
    "@date-io/date-fns": "^2.11.0",
    "@emotion/react": "^11.4.0",
    "@emotion/styled": "^11.3.0",
    "@fontsource/inter": "^4.5.0",
    "@fontsource/roboto": "^4.5.0",
    "@lottiefiles/react-lottie-player": "^3.3.1",
    "@material-ui/core": "^5.0.0-beta.2",
    "@material-ui/data-grid": "^4.0.0-alpha.34",
    "@material-ui/icons": "^5.0.0-beta.1",
    "@material-ui/lab": "^5.0.0-alpha.41",
    "@material-ui/styled-engine-sc": "^5.0.0-alpha.11",
    "@material-ui/styles": "^5.0.0-beta.2",
    "@material-ui/x-grid": "^4.0.0-alpha.34",
    "@nivo/bar": "^0.73.1",
    "@nivo/core": "^0.73.0",
    "@nivo/pie": "^0.73.0",
    "@nivo/scatterplot": "^0.73.0",
    "@reduxjs/toolkit": "^1.6.1",
    "@types/jest": "^26.0.24",
    "@types/leaflet": "^1.7.4",
    "@types/material-ui": "^0.21.9",
    "@types/node": "^16.4.3",
    "@types/react": "^17.0.15",
    "@types/react-dom": "^17.0.9",
    "@types/react-helmet": "^6.1.2",
    "@types/react-redux": "^7.1.18",
    "@types/react-router-dom": "^5.1.8",
    "@typescript-eslint/eslint-plugin": "^4.28.5",
    "@typescript-eslint/parser": "^4.28.5",
    "@vitejs/plugin-react-refresh": "^1.3.5",
    "animated-number-react": "^0.1.2",
    "clsx": "^1.1.1",
    "date-fns": "^2.23.0",
    "geolib": "^3.3.1",
    "history": "^5.0.0",
    "i18next": "^20.3.5",
    "i18next-browser-languagedetector": "^6.1.2",
    "i18next-http-backend": "^1.2.8",
    "leaflet": "^1.7.1",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-helmet": "^6.1.0",
    "react-i18next": "^11.11.4",
    "react-leaflet": "^3.2.0",
    "react-redux": "^7.2.4",
    "react-router-dom": "^6.0.0-beta.0",
    "react-transition-group": "^4.4.2",
    "styled-components": "^5.3.0",
    "stylelint-config-recommended": "^5.0.0",
    "stylelint-config-styled-components": "^0.1.1",
    "stylelint-processor-styled-components": "^1.10.0",
    "typescript": "^4.3.5",
    "vite": "^2.4.3"
  },
  "devDependencies": {
    "@commitlint/cli": "^13.1.0",
    "@commitlint/config-conventional": "^13.1.0",
    "@types/react": "^17.0.15",
    "@types/react-dom": "^17.0.9",
    "eslint": "^7.31.0",
    "eslint-config-airbnb": "^18.2.1",
    "eslint-config-prettier": "^8.3.0",
    "eslint-import-resolver-typescript": "^2.4.0",
    "eslint-plugin-import": "^2.23.4",
    "eslint-plugin-jsx-a11y": "^6.4.1",
    "eslint-plugin-prettier": "^3.4.0",
    "eslint-plugin-react": "^7.24.0",
    "eslint-plugin-react-hooks": "^4.2.0",
    "husky": "^7.0.1",
    "prettier": "^2.3.2",
    "stylelint": "^13.13.1",
    "stylelint-config-standard": "^22.0.0",
    "typescript": "^4.3.5"
  }
oliviertassinari commented 3 years ago

Duplicate of #2000