search

mui / mui-x

MUI X: Build complex and data-rich applications using a growing list of advanced React components, like the Data Grid, Date and Time Pickers, Charts, and more!
https://mui.com/x/
3.82k stars 1.14k forks source link

[DatePicker] Initial commit #3451

Closed flaviendelangle closed 2 years ago

flaviendelangle commented 2 years ago

Closes #2398

Doc preview Codesandbox pro example

Changes

For the view types, I removed the duplicates and only kept the type with the name of the view component, not the ones with the name of the pickers (clock not time, calendar not date, calendarOrClock not dateTime)

Removing ClockPickerStandalone and instead have ClockPicker handle the controlled / uncontrolled pattern just like in CalendarPicker

PRs ready to be picked:

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

mui-bot commented 2 years ago

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 240.1 477.5 316.3 328.26 85.624
Sort 100k rows ms 477.8 947.2 642 682.5 154.688
Select 100k rows ms 113 224.3 195 188.16 40.008
Deselect 100k rows ms 89.5 216.5 202.6 160.72 50.838

Generated by :no_entry_sign: dangerJS against 5e745688ca4327e17c63f5b5d519cd34ebe888af

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

siriwatknp commented 2 years ago

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder. 2.1 revert the change on those markdown files you did 2.2 pull latest master from upstream (you should not see conflict) 2.3 make the changes again at docs/data/data-grid/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/x/api/data-grid/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

siriwatknp commented 2 years ago

@flaviendelangle Would all the /x/api/date-pickers/* pages be included in this PR?

flaviendelangle commented 2 years ago

@siriwatknp they should yes

github-actions[bot] commented 2 years ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

flaviendelangle commented 2 years ago

@alexfauquette concerning the references to DataGridPro or x-data-grid-pro in the api page, I removed some hardcoded values and synced the ApiPage file with the core (I can't use it directly because we have the concept of slots which they do not document).

alexfauquette commented 2 years ago

I finally found Why date-range-picker description was empty, it's a regexp problem

The current one /date-range-picker.*.json$/ is valid for files such as

The . needs to be escaped and the lang tag must be restrained to 2 letters to avoid accepting "date-range-picker-day"

A solution can be /\/date-range-picker(-[a-z]{2})?\.json$/

flaviendelangle commented 2 years ago

A solution can be /\/date-range-picker(-[a-z]{2})?.json$/

Done