search

mui / tech-challenge-full-stack

This challenge is part of the hiring process for some of the Software Engineer positions at MUI.
MIT License
12 stars 4 forks source link

Refresh challenge #3

Open oliviertassinari opened 1 year ago

oliviertassinari commented 1 year ago

We could:

https://github.com/mui/tech-challenge-full-stack/blob/d7024ec09d831642ebebaf2fb05175063fba8234/package.json#L21

https://github.com/mui/tech-challenge-full-stack/blob/d7024ec09d831642ebebaf2fb05175063fba8234/pages/_document.tsx#L7

Janpot commented 1 year ago

Honestly, I'm not sure we should push candidates even deeper into Next.js's paradigms. It's so opinionated and aimed at the static website use-case. It has these strong constraints on routing, it doesn't support API routes, it's all vendor specific and non-standardized. I'd like to gauge candidates capability to understand the basics of React, and the basic anatomy of web servers. If anything, I think for the future of this challenge we could rather aim towards getting rid of Next.js and offer something more bare bones.

Opening https://github.com/mui/tech-challenge-full-stack/pull/4 already for the dependencies.

oliviertassinari commented 12 months ago

On

Screenshot 2023-10-02 at 17 22 39

this is something that has already surfaced in the past with @samuelsycamore, @danilo-leal, and @mj12albert. I think there is already a general consensus on this, I had the same pain. I have added the point to the TODO list in https://github.com/mui/material-ui/issues/34905 (in cases there is no existing issues about it already)

oliviertassinari commented 12 months ago

Honestly, I'm not sure we should push candidates even deeper into Next.js's paradigms. It's so opinionated and aimed at the static website use-case. It has these strong constraints on routing, it doesn't support API routes, it's all vendor specific and non-standardized. I'd like to gauge candidates capability to understand the basics of React, and the basic anatomy of web servers. If anything, I think for the future of this challenge we could rather aim towards getting rid of Next.js and offer something more bare bones.

@Janpot Should we go down the Vite + express API route then?

Janpot commented 12 months ago

🙂 I typed that comment because I got frustrated with the example. I removed it again after I started playing around with app dir and this challenge and it didn't feel like a good fit. But fair enough, should have signaled this 👍

Should we go down the Vite + express API route then?

I think that would be a good stack for the challenge. The only thing that holds me back from it is https://github.com/vitejs/vite/issues/12423. It would be a pity doing a coding challenge and then have this bug eat all your time.