NodeRuntimeWrapper is not required when deploying app?

[WangLarry]

Duplicates

• [X] I have searched the existing issues

Latest version

• [X] I have tested the latest version

Current behavior 😯

NodeRuntimeWrapper wrap children with ErrorBoundary and NodeRuntimeContext. It maybe bring a little performance loss for one node. But it is common that there are over 30 nodes in one page of real app.

function RenderedNodeContent({ node, childNodeGroups, Component }: RenderedNodeContentProps) {
  ...

  return (
    <NodeRuntimeWrapper nodeId={nodeId} componentConfig={Component[TOOLPAD_COMPONENT]}>
      {isLayoutNode ? (
        <Component {...props} />
      ) : (
        <Box
          sx={{
            display: 'flex',
            alignItems: boundLayoutProps.verticalAlign,
            justifyContent: boundLayoutProps.horizontalAlign,
          }}
        >
          <Component {...props} />
        </Box>
      )}
    </NodeRuntimeWrapper>
  );
}

Expected behavior 🤔

No response

Steps to reproduce 🕹

Steps:

1. 2. 3. 4.

Context 🔦

No response

Your environment 🌎

No response

[apedroferreira]

Thanks for reporting this issue @WangLarry. Not sure how plausible it would be to not to wrap each component with this - we'd also have to measure how much this is affecting performance to see if it's worth tackling.

[Janpot]

I believe it's needed at runtime because we want to be able to show error information on a per-component basis, even in the application runtime. This to avoid crashing the whole application and losing context of where an error is happening.

[WangLarry]

NodeRuntimeContext inside of it is unnecessary.

[Janpot]

NodeRuntimeContext inside of it is unnecessary.

At the moment, it's indeed only used by the editor. But unless there's a significant measurable performance hit, I think we can live with it, the context value should be stable for the lifetime of the component, so I don't expect there to be any problem. I believe there are more important performance issues to focus on in the application runtime.